docs: add try-catch example for setProviderAndWait usage #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhay <abhayakg123@gmail.com.com>
aepfli
approved these changes
Apr 28, 2025
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
|
aepfli
approved these changes
Apr 28, 2025
Member
aepfli
left a comment
aepfli
left a comment
There was a problem hiding this comment.
Thank you! This excellent addition helps us normalize our documentation throughout our SDK landscape.
PS: I fixed the checkstyle issues, so we can go ahead with merging, as soon as we have all the approvals
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
============================================
+ Coverage 92.81% 93.25% +0.44%
- Complexity 469 471 +2
============================================
Files 43 43
Lines 1127 1127
Branches 91 91
============================================
+ Hits 1046 1051 +5
+ Misses 53 48 -5
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chrfwow
approved these changes
Apr 28, 2025
beeme1mr
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1424
This PR improves the README examples by wrapping the setProviderAndWait method inside a try-catch block.
Since setProviderAndWait can throw an exception if the provider initialization fails, it's important to handle it safely to prevent unexpected crashes during runtime.
Changes made:
Why?
Checklist: